misc: Dependabot changes to fix vulnerabilities #282
Merged
Conversation
prkhrkat
requested review from
nishant-d,
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 2303650 | Triggered | Generic High Entropy Secret | 0bcc13c | ci-runner/vendor/github.com/go-resty/resty/v2/request.go | View secret |
| 9416345 | Triggered | Company Email Password | 0bcc13c | ci-runner/vendor/github.com/go-resty/resty/v2/request.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
# Conflicts: # chart-sync/go.mod # chart-sync/go.sum # chart-sync/vendor/modules.txt # ci-runner/go.mod # ci-runner/go.sum # ci-runner/vendor/modules.txt # git-sensor/go.mod # git-sensor/go.sum # git-sensor/vendor/modules.txt # image-scanner/go.mod # image-scanner/go.sum # image-scanner/vendor/modules.txt # kubelink/go.mod # kubelink/go.sum # kubelink/vendor/modules.txt # kubewatch/go.mod # kubewatch/go.sum # kubewatch/vendor/modules.txt # lens/go.mod # lens/go.sum # lens/vendor/modules.txt
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
prakash100198
approved these changes
Jun 5, 2025
vikramdevtron
approved these changes
Jun 5, 2025
prkhrkat
changed the title
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
1 similar comment
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
prkhrkat
changed the title
github-actions
Bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
vikramdevtron
added a commit
that referenced
this pull request
Jun 19, 2025
* SecretFieldClusterId to CmFieldClusterId
* replace secret informer with field selector to configmap informer with label selector
* CreateConfigMapObject
* ClusterModifyEventSecretTypeKey
* DeleteConfigMap k8s util func
* correct label selector
* add extra validation in add , update and delete func
if labelValue, exists := cmObject.Labels["type"]; !exists || labelValue != informerBean.ClusterModifyEventSecretType {
return
}
* cm informer instead of secret informer for cluster
* bump common lib
* bump common lib
* bump common lib
* bump common lib
* fix
* bump common lib
* bump common lib
* r
* ClusterModifyEventCmLabelValue = "cluster-request-modify"
* ClusterModifyEventCmLabelValue = "type=cluster-request-modify"
* import label selector from commonb lib
* import label selector from commonb lib
* ClusterModifyEventCmLabelKeyValue and ClusterModifyEventCmLabelValue
* small fix
* small fix
* add logger for ignoring cluster change event in case label not found
* fix
* logger
* refactoring of CreateConfigMapObject
* fix
* bump common lib
* bump common lib
* remove WithCmName and make cmname as func signature
* code review incorporation
* bump common lib
* make
* bump common lib
* Merge pull request #282 from devtron-labs/dependa-fix
misc: Dependabot changes to fix vulnerabilities
* chore: http shutdown timeout configurable (#291) (#293)
* feat: add server shutdown timeout configuration and improve logging
* feat: add SERVER_SHUTDOWN_TIMEOUT to configuration
Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com>
* restored mod changes for kubelink and kubewatch (#294)
* vendor update on rc 38 (#295)
* chore: port forward tls client server name (#296)
* chore-port-forward-debug
* review comments resolved
---------
Co-authored-by: Prakash Kumar <prakash.kumar@devtron.ai>
Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com>
Co-authored-by: prakhar katiyar <39842461+prkhrkat@users.noreply.github.com>
Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix - https://github.com/devtron-labs/sprint-tasks/issues/2317